[wp-hackers] Committed patch needs tweaking...

[Stephen Rider]

On Nov 26, 2008, at 1:44 AM, Peter Westwood wrote:

> Stephen Rider wrote:
>> In 2.7 we're adding some new hooks, like so:
>>
>> do_action( "after_plugin_row_$plugin_file", $plugin_data, $context );
>>
>> $action_links = apply_filters("plugin_action_links_$plugin_file",  
>> $action_links, $plugin_data, $context);
>>
>> It was my own patch, and it is committed, but I'm starting to think  
>> it should be tweaked a bit.
>>
>> In short, I think we should still be passing the $plugin_file  
>> parameter
>>
>> Can this be fixed before 2.7 final?
> It would seem to make sense to me.
>
> It makes the argument list the same for both hooks then which help  
> people write backward compatible plugins too.
>
> Does anyone have an opposition to this?

Here's the patch -- just needs some admin love. :)

http://trac.wordpress.org/ticket/8356

It would be great to get this into 2.7 so we're not stuck with either

1) reordering parameters in 2.8, or
2) inconsistent parameter order between similar hooks.

Thanks,
Stephen

-- 
Stephen Rider
<http://striderweb.com/>