[wp-hackers] We already know you are awesome,
you don't have to prove it
robin.adr at gmail.com
Sun Jan 6 06:06:49 GMT 2008
I'm pretty sure (well, I hope this is the case) that this was all part of
the "2 am syndrome" -- looking at jumbled code so long it starts to make
sense. It may be a good idea to enforce peer review for big patches, much
like how the Webkit (and others) project does it, so the chance of these
weird pieces of code can be caught and ironed out. I often can't find
mistakes in my code, but it takes only a few seconds for others to find
On Jan 5, 2008 9:43 PM, Jacob Santos <wordpress at santosj.name> wrote:
> Can we keep overly complex code out of the source when it does not need
> to be?
> I've noticed while loops that should be foreach loops (fixed). I've just
> seen code that tests whether a variable is an array without using
> is_array() (will be fixed in patch when finished).
> Yes, you have proven that you are awesome, but you don't need to prove
> it. Now for the love of all that is holy please stop. Overly complex
> code when it does not need to be does not help people decipher your code.
> Thank You.
> Jacob Santos
> http://www.santosj.name - blog
> Also known as darkdragon and santosj on WP trac.
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
More information about the wp-hackers