[wp-hackers] Moving tickets/patches forward

Bob wp-hackers at nj-arp.org
Thu Oct 18 09:27:50 GMT 2007

Ryan, thank you for your reply.

Email address validation is a pain and I know wp-mail.php is 
overly-restrictive on what it accepts.  But at this point, I was simply 
trying to correct the errors in the previous two #5169 patches applied to 
trunk (yes, they made things worse) and fix the specific error mentioned in 
#5169.  My philosophy is that it's not perfect, but it's better than what's 
in WP 2.3, properly handles the vast majority of email addresses, and is 
consistent with email address processing elsewhere in WP.

There are a few ways to approach the issues raised by #4616, #4642, and 
#5169.  I'm thinking:
1. Put in #5169 as it is now to fix the reported errors in wp-mail and fix 
the already-applied bad patches.
2. Put in #4642 to restrict posting in wp-mail to those allowed to post.
3. Expand #4616 to cover wp-mail and implement a general solution on email 

Does that sound OK to you, or would you prefer a different approach?  Note 
that a general solution also requires changes to is_email and sanitize_email 
in formatting.php, as they only allow the same (overly-restrictive) 
characters as wp-mail allows.


----- Original Message ----- 
From: "Ryan Boren" <ryan at boren.nu>
To: <wp-hackers at lists.automattic.com>
Sent: Thursday, October 18, 2007 1:36 AM
Subject: Re: [wp-hackers] Moving tickets/patches forward

> On 10/17/07, Callum Macdonald <lists.automattic.com at callum-macdonald.com> 
> wrote:
>> I think this raises an interesting point. Is there actually a process
>> for making contributions or decisions in WordPress? Or is it just what
>> the core devs do, when they do it?
>> I realise there's a great deal of discussion on the list, and that's
>> great. I know that I've personally noticed westi replying to lots of
>> stuff and accepting patches. Is that it, is that the process?
>> http://codex.wordpress.org/Core_Patch_Submission
>> This page is currently blank. It would be nice if there was something
>> here explaining how patches should be submitted.
> http://codex.wordpress.org/Submitting_Bugs covers some of this.  Not
> sure what's with the Core Patch Submission page.
> Patch commits tend to happen in cycles.  Right now we've been getting
> 2.3.1 ready and doing some architectural stuff to 2.4.  Small bugs
> milestoned for 2.4 are kinda on the back burner.  In the case of
> #5169, it's a bug in the somewhat orphaned and neglected wp-mail and
> involves email related regular expressions, which are a pain. For an
> example of what a pain it is to handle all cases for an email address:
> http://trac.wordpress.org/attachment/ticket/4616/4616b.diff
> Such bugs tend to get shuffled to the back of development priorities.
> But, the thing to do if you care about a bug that isn't getting
> traction is just what's been done here.  Add a note to trac and bring
> it up on this list to see if anyone wants to take up the cause.
> Anyhow, I added some notes to the ticket.
> Ryan
> _______________________________________________
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
> http://lists.automattic.com/mailman/listinfo/wp-hackers 

More information about the wp-hackers mailing list