[wp-hackers] WP Includes Plugin API is still broken

[Jacob]

Several patches were submitted that fixed the bugs that came up with the 
refactoring a while back. However, none of the patches were applied for 
whatever reason. If the reason for why the patches were rejected are 
given, then a new patch can be made to correct the problems with the 
Plugin API.

http://trac.wordpress.org/ticket/5225 - fixes @since information and 
brings the short description in line with the coding standards.

http://trac.wordpress.org/ticket/5163 - fixes filter documentation, 
simple patch. Patch might not still apply.

http://trac.wordpress.org/ticket/5338 - Applies what is in #5225 and 
#5163, as well as fix several issues with the current Plugin API code. 
Patch should still apply, but I can update the patch if needed.

The trac ticket 5338 is misleading, what is stated in the description is 
not followed through and only the fixes above as well as minor 
performance improvements are applied. It was found that several of the 
theories, were in practice, debunked. I still think that the patch in 
5338 should be applied to correct the current issues with merge filters, 
as well as close out two other tickets.

If that is unacceptable, then I can split up the patch and submit the 
parts to the respective tickets. I would just have rather not do so. The 
second question is whether the short description needs to be fixed at 
all. I do not feel that plugins.php is ready with the current mistakes.

Oh yes, there isn't a ticket (for such a trivial issue), but during the 
reverting of the refactoring for wp_actions, the $wp_actions global that 
was unset in wp-settings.php was not removed along with those in 
plugins.php. It would be better to remove the variable as it is no 
longer used.



-- 

Jacob Santos

http://www.santosj.name - blog
http://wordpress.svn.dragonu.net/unittest/ - unofficial WP unit test suite.

Also known as darkdragon and santosj on WP trac.