[wp-hackers] Adding wp-includes/class folder
wordpress at tekartist.org
Fri Aug 31 14:40:45 GMT 2007
3rd party libs are always an issue in this kind of restructuration.
For this reason, I always make a habit of having all 3rd party
dependencies in their own specific subtree so that there is a clear
distinction and do not feel compelled to apply my convention to these
pieces. Then I have a simple wrapper implementing/including the 3rd
party software, which itself respects the convention.
A side advantage is that the wrapper allows me (very often) to switch
the said 3rd party software to another provider when a better
solution comes along or allow library choices when available (such as
different caching mechanisms, locale support systems, etc).
I know it sounds heavy, but it pays off in flexibility in the long term.
On Aug 31, 2007, at 10:02, Kimmo Suominen wrote:
> On Fri, Aug 31, 2007 at 02:13:41PM +0100, Peter Westwood wrote:
>> For things like IXR / POP3 support / PHPMailer - splitting the
>> out is a really bad plan IMHO - they are external libraries that we
>> include and we need an easy way of diffing between our version (with
>> some patches) and the upstream version so as to make it easy to
>> pull in
> Similarly renames and code shuffling between files easily creates
> a lot of extra work, as svn isn't smart enough to merge changes
> from changed files into the new file (let alone the new location
> of a file fragment, e.g. when a function is moved to another file).
> Such changes shouldn't be made lightly, in my very humble opinion.
> Best regards,
> + Kimmo
> P.S. Any svk gurus around willing to tell me what I'm doing wrong?
> <A HREF="http://kimmo.suominen.com/">Kimmo Suominen</A>
> wp-hackers mailing list
> wp-hackers at lists.automattic.com
More information about the wp-hackers