[wp-hackers] rev 2455 bug

[Kimmo Suominen]

On Fri, Mar 18, 2005 at 12:23:59AM -0500, Kimmo Suominen wrote:
> I believe this change should have used the defined() function, not the
> constant() function.
> 
> I'm emailing here as well because in rev 2455 the admin interface is
> currently broken due to this.

More correctly: it is broken when using "error_reporting = E_ALL",
which is what I have by default...

+ Kim


> Filed Mosquito #1131 with a patch.
> 
> Regards,
> + Kim
> -- 
> <A HREF="http://kimmo.suominen.com/">Kimmo Suominen</A>
> 
> 
> --- trunk/wp-includes/functions.php	2005-03-17 18:15:18 UTC (rev 2454)
> +++ trunk/wp-includes/functions.php	2005-03-17 23:34:06 UTC (rev 2455)
> @@ -303,7 +303,7 @@
>  
>  function get_settings($setting) {
>    global $wpdb, $cache_settings, $cache_nonexistantoptions;
> -	if ( strstr($_SERVER['REQUEST_URI'], 'wp-admin/install.php') )
> +	if ( strstr($_SERVER['REQUEST_URI'], 'wp-admin/install.php') || constant('WP_INSTALLING') )
>  		return false;
>  
>  	if ( empty($cache_settings) )
>