[glotpress-updates] [GlotPress] #436: Pluralized originals with different placeholders in singular/plural cause a false warning

[GlotPress]

#436: Pluralized originals with different placeholders in singular/plural cause a
false warning
----------------------+-----------------------------
  Reporter:  akirk    |      Owner:
      Type:  defect   |     Status:  new
  Priority:  normal   |  Milestone:  Awaiting Review
 Component:  General  |    Version:
Resolution:           |   Keywords:  has-patch
----------------------+-----------------------------
Changes (by akirk):

 * cc: wordpress@… (added)


Comment:

 This now includes some unit tests, I have changed the behavior of
 `GP_Translation_Warnings::check()` which I discovered in French (because
 of `plural_expression = 'n > 1'`) had the problem that both singular and
 plural were checked against the same translation, thus causing warnings
 when there were a different number of placeholders in the originals.

 The patch now includes some unit tests to demonstrate the problems. They
 fail without my patch for warnings.php.

 The builtin tests were ok but this problem stayed undetected because of
 the missing coverage of  `GP_Translation_Warnings::check()`.

--
Ticket URL: <https://glotpress.trac.wordpress.org/ticket/436#comment:4>
GlotPress <https://glotpress.trac.wordpress.org>
Easy comin', easy goin'