[glotpress-updates] [GlotPress] #299: Profile should have Project Shortcuts
GlotPress
noreply at wordpress.org
Mon Jun 9 13:56:52 UTC 2014
#299: Profile should have Project Shortcuts
-------------------------+-------------------------------------------------
Reporter: | Owner: Secretmapper
Secretmapper | Status: assigned
Type: | Milestone: 1.1
enhancement | Version:
Priority: normal | Keywords: needs-unit-tests has-patch needs-
Component: interface | refresh
Resolution: |
-------------------------+-------------------------------------------------
Comment (by markoheijnen):
I checked the code and here are some of my thoughts:
- The code changes in gp-includes/routes/profile.php are not easy to read.
Like {{{$shortcut = &$shortcuts[$contrib->id];}}} doesn't do a lot since
it should always be empty.
- Don't add javascript in gp-templates/profile.php
- Use wp_enqueue_script for https://www.google.com/jsapi.
I will play with the code later today and give feedback on the UI by
tomorrow.
--
Ticket URL: <https://glotpress.trac.wordpress.org/ticket/299#comment:7>
GlotPress <https://glotpress.trac.wordpress.org>
Easy comin', easy goin'
More information about the glotpress-updates
mailing list