[glotpress-updates] [GlotPress] #299: Profile should have Project Shortcuts
GlotPress
noreply at wordpress.org
Mon Jun 2 21:14:14 UTC 2014
#299: Profile should have Project Shortcuts
---------------------------+--------------------------
Reporter: Secretmapper | Owner: Secretmapper
Type: enhancement | Status: assigned
Priority: normal | Milestone: 1.1
Component: interface | Version:
Resolution: | Keywords:
---------------------------+--------------------------
Comment (by yoavf):
Love the overall functionality. Nice work Arian.
Some notes:
1. Let's drop the number of recent projects to 5
2. I'm seeing {{{Undefined offset: 2 in /srv/www/glotpress/htdocs/gp-
includes/routes/profile.php on line 17}}} multiples times with different
offsets. You probably want {{{! isset()}}} instead of {{{is_null()}}}
3. In your gp-includes/template.php change, you're doing {{{esc_html}}} on
the content. That's important, but escaping should be done as late as
possible. I'd remove it form here and add it where the output happens.
4. In gp-templates/profile.php you have a string made of multiple parts
such as {{{_e( ", Translated: " )}}} and {{{_e( ", Fuzzy: " )}}}. This
should all be combined in one string with (s)printf.
--
Ticket URL: <https://glotpress.trac.wordpress.org/ticket/299#comment:4>
GlotPress <https://glotpress.trac.wordpress.org>
Easy comin', easy goin'
More information about the glotpress-updates
mailing list