[glotpress-updates] [GlotPress] #217: Record validator username when importing
GlotPress
noreply at wordpress.org
Sun Nov 11 12:32:09 UTC 2012
#217: Record validator username when importing
----------------------+-------------------------------------------------
Reporter: jenia | Owner: sushkov
Type: defect | Status: assigned
Priority: normal | Milestone: 1.0
Component: general | Version: 0.1
Resolution: | Keywords: has-patch needs-testing 2nd-opinion
----------------------+-------------------------------------------------
Changes (by sushkov):
* owner: => sushkov
* status: new => assigned
Comment:
Replying to [comment:4 dimadin]:
> Replying to [comment:3 sushkov]:
> > A did a short review and was not sure we need the new `set_user_id`
method, since changing `$entry['user_id']` should have the same results.
>
> True, but I thought that it might get used later as a standalone.
Ideally, we should not touch code that's not relevant to this ticket. Hope
you are ok with this :)
> >
> > Also, could you add a test for this patch?
>
> Unfortunately no, I (still) don't work with unit tests.
I'll take a look later at the patch and write a test case. After what we
get this committed.
Thanks for the patch!
--
Ticket URL: <http://glotpress.trac.wordpress.org/ticket/217#comment:5>
GlotPress <http://glotpress.trac.wordpress.org>
Easy comin', easy goin'
More information about the glotpress-updates
mailing list