[buddypress-trac] [BuddyPress Trac] #9304: 'no-js' body class not being added correctly since BuddyPress 12.1.0

[buddypress-trac]

#9304: 'no-js' body class not being added correctly since BuddyPress 12.1.0
--------------------------+--------------------------
 Reporter:  r-a-y         |       Owner:  espellcaste
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  14.5.0
Component:  Templates     |     Version:  12.1.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------------

Comment (by dcavins):

 OK I see. We wanted to negate this statement:
 `if ( is_buddypress() || ! apply_filters(
 'bp_enqueue_assets_in_bp_pages_only', true ) )  { ... }`

 so could have written
 `if ( ! ( is_buddypress() || ! apply_filters(
 'bp_enqueue_assets_in_bp_pages_only', true ) ) )  { ... }`

 but chose to solve it out. According to the rules of logic (De Morgan?)
 the negation should be
 `if ( ! is_buddypress() && apply_filters(
 'bp_enqueue_assets_in_bp_pages_only', true ) )  { ... }`

 Thanks for catching this!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9304#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac