[buddypress-trac] [BuddyPress Trac] #9307: closedir() should be called conditionally

[buddypress-trac]

#9307: closedir() should be called conditionally
--------------------------+------------------------------
 Reporter:  GaryJ         |       Owner:  johnjamesjacoby
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  14.5.0
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  commit        |
--------------------------+------------------------------
Changes (by espellcaste):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"14157" 14157]:
 {{{
 #!CommitTicketReference repository="" revision="14157"
 Core: improve PHP8 compatibility by only calling `closedir()` on proper
 `opendir()` resources.

 The intent of this change is to avoid `closedir()` producing warnings &
 errors when `opendir()` had previously returned false.

 It also adds a missing `closedir()` call to the
 `bp_attachments_cover_image_generate_file()` function.

 Props GaryJ.

 Fixes #9307 (14.0)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9307#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac