[buddypress-trac] [BuddyPress Trac] #9301: Template notice not displayed for logged-out users when clicking on email unsubscribe link

[buddypress-trac]

#9301: Template notice not displayed for logged-out users when clicking on email
unsubscribe link
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Emails        |    Version:  2.7
 Severity:  normal        |   Keywords:  dev-feedback
--------------------------+-----------------------------
 If a user is logged out and clicks on the Unsubscribe link from one of
 their BuddyPress emails, the user will land on their profile page and the
 page is supposed to display a template notice:
 https://github.com/buddypress/buddypress/blob/33e618df29df7126edd6d714147589bdf2370ba1/src
 /bp-core/bp-core-functions.php#L4594-L4596

 But no message is displayed to the user because `bp_core_setup_message()`
 only works for logged-in users:
 https://github.com/buddypress/buddypress/blob/33e618df29df7126edd6d714147589bdf2370ba1/src
 /bp-core/bp-core-functions.php#L1645-L1647

 This is still the case in v14.3.4, however interestingly, trunk has
 removed the `is_user_logged_in()` clause from
 `bp_core_setup_message()`:https://github.com/buddypress/buddypress/blob/8c0406454b260566fb17fc6cb21d755838eac675/src
 /bp-core/bp-core-functions.php#L1664-L1667, but I cannot find the commit
 that did this.

 Would it make sense to port back trunk's `bp_core_setup_message()` change
 to v14-branch?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9301>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac