[buddypress-trac] [BuddyPress Trac] #8544: Messages sent at the same time can encounter a race condition where they share the same thread_id

[buddypress-trac]

#8544: Messages sent at the same time can encounter a race condition where they
share the same thread_id
----------------------------------------+--------------------------
 Reporter:  petersmithrestless          |       Owner:  espellcaste
     Type:  enhancement                 |      Status:  assigned
 Priority:  low                         |   Milestone:  15.0.0
Component:  Messages                    |     Version:  1.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+--------------------------
Changes (by espellcaste):

 * type:  defect (bug) => enhancement
 * milestone:  Under Consideration => 15.0.0


Comment:

 I was hoping to find a way to unit test or replicate this issue, but it's
 unlikely. Fair to say the suggested approach/patch is a good one, in
 general.

 By using a subquery, the "fetch" and insert requests are performed by
 mysql in the same connection. So we don't want the risk of a race
 condition, and it is, in theory, more performant.

 https://github.com/buddypress/buddypress/pull/399/

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8544#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac