[buddypress-trac] [BuddyPress Trac] #8544: Messages sent at the same time can encounter a race condition where they share the same thread_id

[buddypress-trac]

#8544: Messages sent at the same time can encounter a race condition where they
share the same thread_id
----------------------------------------+--------------------------
 Reporter:  petersmithrestless          |       Owner:  espellcaste
     Type:  enhancement                 |      Status:  closed
 Priority:  low                         |   Milestone:  15.0.0
Component:  Messages                    |     Version:  1.0
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+--------------------------
Changes (by espellcaste):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"14075" 14075]:
 {{{
 #!CommitTicketReference repository="" revision="14075"
 Messages: Use a mysql subquery to insert the `thread_id` while inserting a
 new thread message.

 By moving the `thread_id` insertion into a subquery, we can avoid race
 conditions where two messages are sent at the same time and both use the
 same `thread_id`.

 Props imath and petersmithrestless.

 Closes https://github.com/buddypress/buddypress/pull/399
 Fixes #8544
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8544#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac