[buddypress-trac] [BuddyPress Trac] #9136: Blogs loop not working property when blog has no description

[buddypress-trac]

#9136: Blogs loop not working property when blog has no description
-----------------------------------+---------------------
 Reporter:  lenasterg              |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  14.0.0
Component:  Blogs                  |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+---------------------
Changes (by imath):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 Hi @lenasterg

 I've looked into this. With a regular BuddyPress usage, I can't reproduce
 and the unit tests we perform after each PR or commit can't too.

 We do not provide any UI or ways to edit records we have into the
 `wp_bp_user_blogs_blogmeta` table. Data are simply there to have a single
 table to get all sites options which are in many wp_{site_id}_options
 table in a WordPress multisite config.

 These records are updated each time you update a site option from the
 WordPress General option screen for example.

 So the `description` blogmeta always exists. It can only be empty if the
 site has no description, but even in this case sites with empty
 descriptions are included into results.

 If into the `wp_bp_user_blogs_blogmeta` table you have no `description`
 meta key for sites with empty `blogdescription`, try to repopulate blog
 records using this
 [https://github.com/buddypress/buddypress/blob/master/docs/user/administration/tools/repair.md#5
 -repopulate-site-tracking-records repair tool]. If it's not fixing the
 issue, there's probably a plugin or a script which is messing with
 BuddyPress on your setup.

 That being said, you are right we should improve these queries and
 probably enjoy `WP_Network_Query`.

 Your suggestion doesn't seem to hurt according to unit tests so unless
 there's a strong opinion, I'll probably commit your PR.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9136#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac