[buddypress-trac] [BuddyPress Trac] #9158: Group members not notified that they have been promoted in Nouveau

[buddypress-trac]

#9158: Group members not notified that they have been promoted in Nouveau
--------------------------------------+---------------------
 Reporter:  needle                    |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  14.0.0
Component:  Groups                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |
--------------------------------------+---------------------
Changes (by prbot):

 * keywords:  needs-patch => has-patch has-unit-tests


Comment:

 ''This ticket was mentioned in
 [https://github.com/buddypress/buddypress/pull/293 PR #293] on
 [https://github.com/buddypress/buddypress/ buddypress/buddypress] by
 [https://github.com/imath imath].''
 Hi @needle

 Just checked, I believe we actually need to update BuddyPress and the BP
 REST API.

 - BuddyPress: it shouldn't use the current hooks as there can be
 situations where the hook is fired although the requested action failed.
 - BuddyPress `groups_$action_member()` function should be usable outside
 of the Web version using the BP REST API for instance. It's not currently
 the case and I suspect it to be the reason why we were directly using
 `BP_Groups_Member->$action()`
 - The BP REST API should absolutely use `groups_$action_member()`
 functions to be sure cache is cleared or group activities are deleted when
 it's needed. It's currently not the case. I'll soon submit a PR to the BP
 REST API GH repo.

 Trac ticket: https://buddypress.trac.wordpress.org/ticket/9158

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9158#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac