[buddypress-trac] [BuddyPress Trac] #9125: ctype_digit(): Argument of type int will be interpreted as string in the future

[buddypress-trac]

#9125: ctype_digit(): Argument of type int will be interpreted as string in the
future
-------------------------+--------------------------
 Reporter:  shawfactor   |       Owner:  espellcaste
     Type:  enhancement  |      Status:  closed
 Priority:  low          |   Milestone:  14.0.0
Component:  Core         |     Version:  12.3.0
 Severity:  trivial      |  Resolution:  fixed
 Keywords:  has-patch    |
-------------------------+--------------------------

Comment (by espellcaste):

 @pashavlasovskh4 I'm not sure if the approach is a best practice. I'd
 argue that using `ctype_digit` is outdated. But we make use of it, and not
 breaking or causing PHP warnings was the main goal.

 Unless you have evidence that shows the current approach impacts
 performance or reliability, I don't see a problem with it.

 There is not much to gain in spending a lot of time to find the perfect
 solution to fix something like this, IMO.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9125#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac