[buddypress-trac] [BuddyPress Trac] #8728: Group Moderator Unable Delete Group Posts

[buddypress-trac]

#8728: Group Moderator Unable Delete Group Posts
-------------------------------------------------+-------------------------
 Reporter:  kainelabsteam                        |       Owner:  emaralive
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  14.0.0
Component:  Groups                               |     Version:  10.3.0
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch has-unit-     |
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by needle):

 @emaralive I see that your patch changes
 [https://github.com/buddypress/buddypress/commit/13c1db612f257a206993f4e908404ec841453d3e
 #diff-cd2ff7923180ee641bf6fa18fd36286aba453a454dc22089a74923486becf39aR637
 this line in the filter callback]. I agree that it currently looks wrong -
 but are you sure that your change does what it's supposed to do? It looks
 to me like it should read:

 {{{#!php
 if ( ! isset( $activity->component ) || 'groups' !== $activity->component
 ) {
 }}}

 Your change to `&&` allows Activities with no component at all to be
 processed as Group Activities.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8728#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac