[buddypress-trac] [BuddyPress Trac] #9218: Do we need to edit activity visibility when a user is marked as spam?

[buddypress-trac]

#9218: Do we need to edit activity visibility when a user is marked as spam?
--------------------------+------------------------
 Reporter:  imath         |       Owner:  emaralive
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  15.0.0
Component:  Activity      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------

Comment (by emaralive):

 I alluded to that notion in #8728 and the following is an excerpt
 (specifically, the last table row):
 ----

 == **Mark/Unmark User as Spammer**
 Only available to **site admin** via various locations
 * Backend - [All] Users screen/page.
 * Backend - Individual User's **Extended Profile** screen/page - Status
 metabox.
 * Frontend - Individual User's **Members Capabilities** screen/page, e.g.
 site.url//members/{user}/settings/capabilities/

  Note:: **1.** **user_status** is a field in the **users** table.[[BR]]
 **2.** **hide_sitewide** is a field in the **bp_activity** table, visible
 from backend - activity page/screen.[[BR]] **3.** **is_spam** is a field
 in the **bp_activity** table, visible from backend - activity page/screen
 - spam tab.

 ||= **state** =||= **user_status** =||= **hide_sitewide** =||= **is_spam**
 =||= **Note** =||
 || Normal ||  0  ||  0  ||  0  ||
 || Spammed ||  1  ||  1  ||  1  ||Kicked from site unable to log back in
 until unspammed.  ||
 || Unspammed ||  0  ||  1  ||  0  ||Able to log in, but previous activity
 post are hidden  ||
 ----
 That stated, I believe we need to game out various scenarios that should
 shed light as to what should actually occur or maybe these situations
 don't matter, e.g.:
 - User has some activities marked as spam and then is classified as a
 spammer.
 - User is classified as spammer from initial behavior (broke a site rule,
 as an example)
 - User was accidentally/unduly classified as a spammer.

 However, one would think that if a user is "**marked as ham**"
 (unspammed/not spam) their activities should have "**hide_sitewide**" set
 back to 0 (zero). IIRC, currently the site admin has to do that manually
 by manipulating the "**bp_activity**" table. This opens another can of
 worms because the "**hide_sitewide**" field allows a "**{{{null}}}**" to
 be set (see [https://github.com/buddypress/buddypress/blob/master/src/bp-
 core/admin/bp-core-admin-schema.php#L137 src/bp-core/admin/bp-core-admin-
 schema.php#L137]), which appears to keep the activity hidden.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9218#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac