[buddypress-trac] [BuddyPress Trac] #9218: Do we need to edit activity visibility when a user is marked as spam?

[buddypress-trac]

#9218: Do we need to edit activity visibility when a user is marked as spam?
--------------------------+-----------------------
 Reporter:  imath         |      Owner:  emaralive
     Type:  defect (bug)  |     Status:  assigned
 Priority:  normal        |  Milestone:  15.0.0
Component:  Activity      |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------
 Hi @emaralive,

 Could you have a look at this?

 When marking a user as spam in `bp_core_process_spammer_status()` we are
 updating their activity visibility to `hide_sitewide = 1`.

 And we are also marking these activities as spam in
 `bp_activity_spam_all_user_data()` and running another update query to
 `SET is_spam = 1`

 => imho we could run one update query to set `is_spam` and `hide_sitewide`
 to save a query...

 If the same user is marked as ham: in `bp_activity_ham_all_user_data()` we
 are updating `is_spam` accordingly but not `hide_sitewide`: meaning
 corresponding activities will only show on user's profile page when he's
 viewing his own profile, they shouldn't be listed into the BP Activity
 directory if I guess well.

 Is this the behavior we should use?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9218>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac