[buddypress-trac] [BuddyPress Trac] #9145: Move the BP REST API into BuddyPress core

[buddypress-trac]

#9145: Move the BP REST API into BuddyPress core
--------------------------------------+--------------------------
 Reporter:  espellcaste               |       Owner:  espellcaste
     Type:  task                      |      Status:  assigned
 Priority:  normal                    |   Milestone:  15.0.0
Component:  REST API                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |
--------------------------------------+--------------------------

Comment (by espellcaste):

 @imath  I think we have not, or I have not, released a V2 yet due to lack
 of a strong motive. Since currently, the V2 would only change the shape of
 the returned object, we have been waiting for more possible breaking
 changes or features. **So, if we all agree, we can add a V2 in BuddyPress
 15.0.0 to resolve this inconsistency, because this addition would be minor
 and low risk. I can add V2 as part of 15.0 :)**

 Now, for the V1 removal from the plugin and putting into BP Classic, I
 personally don't see the need there. We could keep both APIs available,
 which is something common in [https://woocommerce.github.io/woocommerce-
 rest-api-docs/#introduction related plugins]. To me, moving to BP Classic
 would be the approach if we were deprecating V1, and we would not support
 fixes and etc, which I don't think that's what you are suggesting. And
 it'd defeat the purpose of the ticket, since we would still continue to
 have another plugin to manage things, which is what I was trying to
 resolve here. =P

 Beyond all that, we could extend the V1 controllers/classes and reuse most
 of the code, since V2 is not that different from V1 (except for the
 returned object shape).

 But the main argument against bundling V1 into BP Classic is it'd defeat
 the purpose of the ticket, unless we plan to deprecate it and not add
 fixes into it.

 --

 And if this doesn't make sense, we can bundle V1 into BP Classic too. I'd
 defer to you here. It'd be good to understand what sort of support it
 would have there. Do we add fixes into it later? Do we have a setting to
 activate it or just installing the plugin is enough? Just by having BP
 Classic, do we get V1 too?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9145#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac