[buddypress-trac] [BuddyPress Trac] #9214: Unit tests: Flaky membership controller test: `test_get_paginated_items` (was: Unit tests: Membership controller test `test_get_paginated_items` is flaky)

[buddypress-trac]

#9214: Unit tests: Flaky membership controller test: `test_get_paginated_items`
-------------------------+--------------------------
 Reporter:  espellcaste  |       Owner:  espellcaste
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  15.0.0
Component:  REST API     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+--------------------------
Description changed by espellcaste:

Old description:

> Sometimes this test fails because the returned items order is not the
> same.
>
> See:
> https://github.com/buddypress/buddypress/actions/runs/9967560534/job/27541438472?pr=337
>
> See:
> https://github.com/buddypress/buddypress/actions/runs/9967560494/job/27541436153?pr=337
>
> {{{
> 1) BP_Test_REST_Group_Membership_V1_Controller::test_get_paginated_items
> Failed asserting that two arrays are equal.
> --- Expected
> +++ Actual
> @@ @@
>  Array (
>     0 => 2015
>     1 => 2016
>     0 => 2012
>     1 => 2013
>     2 => 2017
>  )
> }}}
>
> It's not to me why it fails sometimes. But let's make it test more
> deterministic.

New description:

 Sometimes this test fails because the returned items order is not the
 same.

 See:
 https://github.com/buddypress/buddypress/actions/runs/9967560534/job/27541438472?pr=337

 See:
 https://github.com/buddypress/buddypress/actions/runs/9967560494/job/27541436153?pr=337

 {{{
 1) BP_Test_REST_Group_Membership_V1_Controller::test_get_paginated_items
 Failed asserting that two arrays are equal.
 --- Expected
 +++ Actual
 @@ @@
  Array (
     0 => 2015
     1 => 2016
     0 => 2012
     1 => 2013
     2 => 2017
  )
 }}}

 It's not clear to me why it fails sometimes. But let's make it more
 deterministic.

--

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9214#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac