[buddypress-trac] [BuddyPress Trac] #9052: Duplicate "page on front" option values when BP Classic Add-on is activated

[buddypress-trac]

#9052: Duplicate "page on front" option values when BP Classic Add-on is activated
----------------------------------------------+---------------------
 Reporter:  emaralive                         |       Owner:  imath
     Type:  defect (bug)                      |      Status:  closed
 Priority:  normal                            |   Milestone:  12.1.0
Component:  Core                              |     Version:  12.0.0
 Severity:  normal                            |  Resolution:  fixed
 Keywords:  has-patch has-screenshots commit  |
----------------------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13688" 13688]:
 {{{
 #!CommitTicketReference repository="" revision="13688"
 Add directory post type entries to "page on front" choices if needed

 When the `rewrites` URL parser is in use, to preserve the possibility to
 use  a BuddyPress directory as the site's front page, we need to append
 the corresponding post type IDs to the available pages listed into the WP
 "page on front" reading setting as BP Directories are stored as
 `buddypress` post types instead of the `page` one.

 On the other hand, when the `legacy` URL parser is in use (eg: BP Classic
 is active), to prevent duplicates, it's important to leave the "page on
 front" reading setting choices the way WP sets it as BP Directories are
 stored as `page` post types.

 Props emaralive

 Fixes #9052 (branch 12.0)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9052#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac