[buddypress-trac] [BuddyPress Trac] #9052: Duplicate "page on front" option values when BP Classic Add-on is activated

[buddypress-trac]

#9052: Duplicate "page on front" option values when BP Classic Add-on is activated
---------------------------------------+---------------------
 Reporter:  emaralive                  |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  12.1.0
Component:  Core                       |     Version:  12.0.0
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |
---------------------------------------+---------------------

Comment (by imath):

 Thanks for looking into each option and for your detailed explanation. I
 think that when the `bp_core_include_directory_on_front()` will be used by
 our filter, `bp_core_get_query_parser()` should be available.

 @emaralive Could you test adding this kind of check at the very beginning
 of the `bp_core_include_directory_on_front()` function's code?

 {{{
 function bp_core_include_directory_on_front( $pages = array(), $args =
 array() ) {
         if ( 'rewrites' !== bp_core_get_query_parser() ) {
                 return $pages;
         }
 }}}

 I believe it's the fix we should include into 12.1.0.
 Thanks in advance.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9052#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac