[buddypress-trac] [BuddyPress Trac] #9094: Every click on Load more "eats" some posts.

[buddypress-trac]

#9094: Every click on Load more "eats" some posts.
--------------------------------------+---------------------
 Reporter:  testovac                  |       Owner:  imath
     Type:  defect (bug)              |      Status:  closed
 Priority:  omg pizza                 |   Milestone:  12.3.0
Component:  Activity                  |     Version:  11.0.0
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |
--------------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13725" 13725]:
 {{{
 #!CommitTicketReference repository="" revision="13725"
 Activity: make sure streams are paginated the right way

 In [13344] we made sure to avoid the last entry(ies) of the stream to be
 duplicated if some other members published other entry(ies) just before a
 user clicked on the "Load More" link.

 2 mistakes were made while generating the `BP_Activity_Activity` MySQL
 query clause as well as the Load More link query variable causing a
 regression as some activity entries were wrongly skipped from display each
 time a user was clicking on this link.

 1. The MySQL query clause built in
 `BP_Activity_Activity::get_filter_sql()` needs to also include the last
 inserted Activity ID using the `<=` operator instead of the `<` one.
 2. The query variable added to the Load More link needs to remain the last
 inserted Activity ID at the time the stream is first displayed.

 Props testovac
 Antiprops imath

 Fixes #9094 (branch 12.0)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9094#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac