[buddypress-trac] [BuddyPress Trac] #9210: Review the way we load 12.0.0 deprecated code

[buddypress-trac]

#9210: Review the way we load 12.0.0 deprecated code
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  14.1.0
Component:  Core                                 |     Version:  14.0.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |
  feedback has-testing-info                      |
-------------------------------------------------+-------------------------

Comment (by imath):

 Hi @emaralive

 Thanks a lot for your amazing work on this. In short I've
 [https://github.com/buddypress/buddypress/pull/352/commits/1b59d9f73805c1444621c843cf4c19068e81e20d
 updated the PR] according to your patch.

 The only thing I've edited is this check `if ( (float) 15 >=
 $current_major_version ) `, because we need to test against the first
 installed version to match what we discussed about during development
 chat. Carry on loading 12.0 deprecated functions until the first install
 version is > 15.0.

 I've split the unit tests in two functions:
 -
 `test_bp_get_deprecated_functions_versions_array_is_consistent_with_deprecated_files()`
 is there to check that when we create a new `/src/bp-
 core/deprecated/X.X.php` file we don't forget to update the
 `$deprecated_functions_versions` to include `X.X` version.
 - `test_bp_get_deprecated_functions_versions()` is checking we include the
 last 2 deprecated function files or all deprecated functions from 12.0 if
 the first installed version is <= 15.0.

 About:
 > there should be a documented "Deprecation Policy"
 I totally agree: https://github.com/buddypress/bp-documentation/issues/290

 Can you confirm the updated PR is fine with you? If so I'll commit it.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9210#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac