[buddypress-trac] [BuddyPress Trac] #9223: Inconsistency is messages

[buddypress-trac]

#9223: Inconsistency is messages
--------------------------+---------------------
 Reporter:  martenw       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  14.1.0
Component:  Groups        |     Version:  14.0.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+---------------------
Changes (by imath):

 * keywords:   => needs-patch
 * milestone:  Awaiting Review => 14.1.0


Comment:

 Hi @martenw

 Thanks a lot for your report. I confirm the issue. It's happening when the
 BP REST API based UI to manage members is not available (eg: the BP Legacy
 template pack is used instead of the BP Nouveau one). In this case we fall
 back to the legacy UI / Admin functions.

 On front-end, an error message is thrown although the members was removed.
 On back-end, @martenw's description is accurate.

 The root cause is a regression I introduced in r13873 during the 14.0
 development cycle. I forgot to return true at the end of the
 `groups_remove_member()` function as @martenw noted.

 I'll work on a fix asap.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9223#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac