[buddypress-trac] [BuddyPress Trac] #9221: [BP Legacy Template pack] A printf function is written incorrectly related to "mentions" count in src/bp-templates/bp-legacy/buddypress/activity/index.php

buddypress-trac noreply at wordpress.org
Fri Aug 2 00:27:46 UTC 2024


#9221: [BP Legacy Template pack] A printf function is written incorrectly related
to "mentions" count in src/bp-templates/bp-
legacy/buddypress/activity/index.php
----------------------------------------------------+---------------------
 Reporter:  emaralive                               |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  14.1.0
Component:  Templates                               |     Version:  14.0.0
 Severity:  normal                                  |  Resolution:
 Keywords:  has-screenshots dev-feedback has-patch  |
----------------------------------------------------+---------------------

Comment (by emaralive):

 @espellcaste OK, let's just move this along and commit your PR as is. As
 previously mentioned your patch works as expected and I ran the tests from
 my linux centos based server and as a template override from the linux
 debian based server with same results for patch and without patch. The
 error messages and new screenshots are from a site on the linux centos
 based server.

 Without patch the error cast for PHP 8.0.30 (see screenshot
 **{{{php80_without_patch.png}}}**):
 {{{
 Fatal error: Uncaught ArgumentCountError: 2 arguments are required, 1
 given in /wp-content/plugins/buddypress/bp-templates/bp-
 legacy/buddypress/activity/index.php:164
 }}}

 Without patch the error cast for PHP 7.4.33 (see screenshot
 **{{{php74_without_patch.png}}}**):
 {{{
 Warning: printf(): Too few arguments in /wp-content/plugins/buddypress/bp-
 templates/bp-legacy/buddypress/activity/index.php on line 164
 }}}

 Screenshot **{{{screenshot-win10-me-2024.07.29-12_29_59 (1).png}}}** (1st
 screenshot posted) represents what it would look like with patch (just
 ignore the comments).

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9221#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list