[buddypress-trac] [BuddyPress Trac] #8728: Group Moderator Unable Delete Group Posts

[buddypress-trac]

#8728: Group Moderator Unable Delete Group Posts
--------------------------------------+------------------------
 Reporter:  kainelabsteam             |       Owner:  emaralive
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  14.0.0
Component:  Groups                    |     Version:  10.3.0
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |
--------------------------------------+------------------------

Comment (by imath):

 Hi @emaralive

 First: thank you so much for the amazing work you accomplished about
 reviewing Group roles capabilities 💪 👏. This work will be very helpful
 to update our documentation and keep things clear about it.

 I'm personaly in favor of adding the "Site Wide" Group's content deletion
 setting you suggested
 + adding another one into the group's management/creation screen on front-
 end.

 Thanks for fixing the `bp_groups_filter_activity_user_can_delete` filter.
 Ideally it should include the `bp_enable_group_activity_deletions()` you
 suggested or something plugin could rely on, eg:
 `bp_enable_group_content_deletions( 'activity' )`.

 One very important thing you need to improve about 8728.02.patch: you
 cannot rely on `buddypress()->groups->current_group->id` or
 `bp_get_current_group_id()` as this global data is only available when a
 group is displayed: it would fail within the REST API context. So the
 right way to get the group's ID the activity is attached to is:
 `$group_id = $activity->item_id;`

 Thanks a lot @espellcaste for working on unit tests, I agree this is
 important.

 Let's wait for 1 more feedback about the Admin / Group Admin settings to
 see if we're fine with adding these. What do you think @dcavins?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8728#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac