[buddypress-trac] [BuddyPress Trac] #8908: Do not neutralize `BP_Component::parse_query()` when BP Rewrites are not in use

[buddypress-trac]

#8908: Do not neutralize `BP_Component::parse_query()` when BP Rewrites are not in
use
--------------------------+---------------------
 Reporter:  imath         |       Owner:  imath
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  12.0.0
Component:  Route Parser  |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by imath):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13492" 13492]:
 {{{
 #!CommitTicketReference repository="" revision="13492"
 Make sure `BP_Component::parse_query()` always run

 Only running it when BP Rewrites are on is not the right way to go as some
 plugins might have been using the WP Rewrites API for a while and might
 have extended this method from their component's class.

 Instead of only running this method if BP Rewrites are on, we're adding a
 URL parser check inside each component having a directory to figure out
 whether it's needed to set BP URI globals.

 See #4954
 Fixes #8908
 Closes https://github.com/buddypress/buddypress/pull/109
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8908#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac