[buddypress-trac] [BuddyPress Trac] #8734: Introduce simple "Private Site" toggle

[buddypress-trac]

#8734: Introduce simple "Private Site" toggle
------------------------------+-----------------------
 Reporter:  dcavins           |       Owner:  (none)
     Type:  feature request   |      Status:  assigned
 Priority:  normal            |   Milestone:  12.0.0
Component:  Core              |     Version:  10.4.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------
Changes (by imath):

 * keywords:  has-patch early => has-patch commit


Comment:

 Hi @dcavins !

 I've just tested the patch. It works great. Thanks a lot for your
 work/reactivity about it. I only have a few last change requests before
 you can commit it:

 1. This feature requires the BP Rewrites API, so we need to add some
 `'rewrites' === bp_core_get_query_parser()` checks before displaying the
 setting & inside the `bp_get_community_visibility()` function.
 2. We should add a default option value for new installs + add an upgrade
 routine (which made me notices the legacy widgets clean-up should be out
 of the post type conditional).
 3. We need to force the `$query->is_page` value to `true` otherwise some
 themes like Twenty-Twenty Three are adding additional content like "Posted
 by ... on ...".
 4. Activity feeds: all except 1 are personal feeds, so the logged-in user
 would access to potential activities about friends, groups, etc.. So we
 don't need to check for other components visibility.
 5. Last one is a detail, we should use another inline docblock description
 than something about `private site`.

 You'll find this 5 change requests in the new complementary patch:
 8734.03.feedbacks.patch. Once applied/improved, let's have this in!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8734#comment:41>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac