[buddypress-trac] [BuddyPress Trac] #8734: Introduce simple "Private Site" toggle

[buddypress-trac]

#8734: Introduce simple "Private Site" toggle
-----------------------------+-----------------------
 Reporter:  dcavins          |       Owner:  (none)
     Type:  feature request  |      Status:  assigned
 Priority:  normal           |   Milestone:  12.0.0
Component:  Core             |     Version:  10.4.0
 Severity:  normal           |  Resolution:
 Keywords:  has-patch early  |
-----------------------------+-----------------------

Comment (by dcavins):

 Hi @imath, thanks for your review!

 Yes, I didn't go down the post_status road, because I've had surprising
 experiences with non-core post statuses in other plugins, that made me use
 a simple option instead. That's not to say we can't use the posts in the
 future. As you said, though, it would be inconsistent because some
 items/components map to pages and some do not.

 I've integrated your feedback patch and moved things around so that the
 code is scattered here and there in core files and relevant places. I'll
 also add a PR against the BP-REST git repo that adds `user_can` checks in
 the permissions checks there.

 I have left the "bp_component" argument in place in the
 `bp_current_user_can( 'bp_view' )` checks. Even though we are not
 currently using them, they would be useful if you wanted to modify the
 behavior using the user_can filters.

 Thanks again!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8734#comment:40>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac