[buddypress-trac] [BuddyPress Trac] #8800: Avoid potential PHP errors when using BuddyPress buttons on front end

[buddypress-trac]

#8800: Avoid potential PHP errors when using BuddyPress buttons on front end
--------------------------+-------------------------
 Reporter:  imath         |      Owner:  imath
     Type:  defect (bug)  |     Status:  assigned
 Priority:  high          |  Milestone:  11.1.0
Component:  Templates     |    Version:  11.0.0
 Severity:  major         |   Keywords:  needs-patch
--------------------------+-------------------------
 [13299], [13300], [13301], [13302] & [13303] introduced a potential
 regression if the corresponding button arguments filter is used by some
 custom code like:

 {{{
 add_filter( 'bp_get_send_public_message_button', '__return_false' );
 }}}

 This was reported @fantamily by here: https://buddypress.org/support/topic
 /say-hi-to-buddypress-11-0-0-la-scala/#post-328004

 Returning false to one the button arguments filter has two different
 effects depending on the active template pack:

 - Legacy -> fatal error (Uncaught TypeError)
 - Nouveau -> Warning (Trying to access array offset on value of type bool)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8800>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac