[buddypress-trac] [BuddyPress Trac] #8844: BP_Friends_Friendship::get_random_friends() reports incorrect results

[buddypress-trac]

#8844: BP_Friends_Friendship::get_random_friends() reports incorrect results
--------------------------------------+---------------------
 Reporter:  boonebgorges              |       Owner:  imath
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  11.2.0
Component:  Friends                   |     Version:  11.0.0
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |
--------------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13428" 13428]:
 {{{
 #!CommitTicketReference repository="" revision="13428"
 Improve comparison consistency in `BP_Friends_Friendship`

 - Fix a bug introduced in [13092] making sure to cast IDs retrieved by
 `$wpdb->results()` as integers when comparing them to another integer
 (user ID).
 - Use strong comparisons everywhere in the class.
 - Add unit tests.

 Props boonebgorges

 Fixes #8844 (branch 11.0)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8844#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac