[buddypress-trac] [BuddyPress Trac] #8844: BP_Friends_Friendship::get_random_friends() reports incorrect results

[buddypress-trac]

#8844: BP_Friends_Friendship::get_random_friends() reports incorrect results
--------------------------------------+---------------------
 Reporter:  boonebgorges              |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  11.2.0
Component:  Friends                   |     Version:  11.0.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |
--------------------------------------+---------------------
Changes (by prbot):

 * keywords:  needs-patch => has-patch has-unit-tests


Comment:

 ''This ticket was mentioned in
 [https://github.com/buddypress/buddypress/pull/68 PR #68] on
 [https://github.com/buddypress/buddypress/ buddypress/buddypress] by
 [https://profiles.wordpress.org/imath/ @imath].''
 - Fix a bug introduced in
 [https://buddypress.trac.wordpress.org/changeset/13092 13092] making sure
 to cast IDs retrieved by `$wpdb->results()` as integers when comparing
 them to another integer (user ID).
 - Use strong comparisons everywhere in the class.
 - Add unit tests.

 Trac ticket: https://buddypress.trac.wordpress.org/ticket/8844

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8844#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac