[buddypress-trac] [BuddyPress Trac] #8974: Typo in URL prevents accepting group memberships

[buddypress-trac]

#8974: Typo in URL prevents accepting group memberships
--------------------------+-----------------------------
 Reporter:  coffee2code   |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Groups        |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 An issue has cropped up recently with group admins on
 profiles.wordpress.org not being able to approve group memberships. After
 clicking the 'Accept' link next to the membership request (on the group's
 frontend 'Manage' tab), they encounter a 404.

 After investigation, I discovered that [13446] changed how group links
 were generated. It looks as though the 'Accept' link generated via
 `bp_get_group_request_accept_link()` has a typo introduced during this
 rewrite, missing the ending 's'. When the request is sent against the
 pluralized path of 'membership-requests' the action completes
 successfully. The associated 'Reject' link generated via
 `bp_get_group_request_reject_link()` uses the pluralized form of
 'membership-requests'.

 Patch attached.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8974>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac