[buddypress-trac] [BuddyPress Trac] #7614: Group member count routine is bad

[buddypress-trac]

#7614: Group member count routine is bad
---------------------------------------------------+-----------------------
 Reporter:  boonebgorges                           |       Owner:  imath
     Type:  enhancement                            |      Status:  assigned
 Priority:  normal                                 |   Milestone:  11.0.0
Component:  Groups                                 |     Version:  1.2.3
 Severity:  normal                                 |  Resolution:
 Keywords:  has-patch has-unit-tests dev-feedback  |
---------------------------------------------------+-----------------------

Comment (by dcavins):

 Replying to [comment:32 imath]:
 > @dcavins Thanks a lot for your interesting patch. I'm pretty sure the
 logic you used will be useful to repair some out of sync user data. I just
 added a PR, I believe is enough to fix this ticket. I finally understood
 what I did 6 months ago. Sorry it took me this long and that I made you
 work on this direction.
 >
 > What the PR does: it simply doesn't apply the inactive users
 neutralization from count when origin was an Admin action.
 >
 > What do you think of it @dcavins ?

 I think your patch is fine. I was a little wary because it adds some hard-
 to-explain logic, but it seems OK. Any accidental overreach of the logic
 is so minimal as to not worth bothering about. (We are only talking about
 the group count here, so if we become aware of an edge case that blows it
 up, well, we can fix it.)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7614#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac