[buddypress-trac] [BuddyPress Trac] #8642: Marking read notifications as unread in bulk not updating object cache (counts)

[buddypress-trac]

#8642: Marking read notifications as unread in bulk not updating object cache
(counts)
-------------------------------------+------------------------------
 Reporter:  niftythree               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Toolbar & Notifications  |     Version:  10.1.0
 Severity:  normal                   |  Resolution:
 Keywords:                           |
-------------------------------------+------------------------------

Comment (by oztaser):

 Hi @niftythree,

 Thanks for the report. The problem is here we don't pass current `is_new`
 value when notification is marked as read/unread and so we can't find the
 notification to be marked for cache invalidation because default value of
 `is_new` is `true`.

 Example query when we are trying to mark notification as unread.

 {{{
 SELECT * FROM wp_bp_notifications n   WHERE id IN (32716634) AND
 component_name IN
 ('xprofile','messages','activity','blogs','members') AND is_new = 1
 }}}

 I've prepared the patch but not sure it's good enough.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8642#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac