[buddypress-trac] [BuddyPress Trac] #8637: Notifications no longer updating counts with object caching since 10.0

[buddypress-trac]

#8637: Notifications no longer updating counts with object caching since 10.0
--------------------------------------------------+---------------------
 Reporter:  niftythree                            |       Owner:  (none)
     Type:  defect (bug)                          |      Status:  new
 Priority:  high                                  |   Milestone:  10.1.0
Component:  Toolbar & Notifications               |     Version:  10.0.0
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-opinion  |
--------------------------------------------------+---------------------
Changes (by imath):

 * keywords:  needs-patch needs-unit-tests => has-patch has-unit-tests 2nd-
     opinion


Comment:

 In
 [https://buddypress.trac.wordpress.org/attachment/ticket/8637/8637.patch
 8637.patch] I've added 2 unit tests, it's not easy to find them as I've
 moved cache functions that were in
 `tests/phpunit/testcases/notifications/functions.php` into a new file:
 `tests/phpunit/testcases/notifications/cache.php` You can look for
 `@ticket BP8637` to find these.

 @oztaser I think we do not need to introduce new hooks and functions for
 this case, we can use existing hooks and functions. I think it's safe to
 add an `ids` key to the `$where_args` array when bulk updating
 notifications and an `id` key to the `$args` array when bulk deleting.

 What's your opinion about it?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8637#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac