[buddypress-trac] [BuddyPress Trac] #8623: Profile Fields "Custom" Sort Order not working since 10.0

[buddypress-trac]

#8623: Profile Fields "Custom" Sort Order not working since 10.0
------------------------------+---------------------
 Reporter:  niftythree        |       Owner:  imath
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  10.1.0
Component:  Core              |     Version:  10.0.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13231" 13231]:
 {{{
 #!CommitTicketReference repository="" revision="13231"
 Bring back `custom` order to xProfile field options sorting

 r13147 introduced a regression about this type of xProfile field options
 order. To make sure we preserve it, we need to check `$this->order_by`
 value before sanitizing it otherwise the potential `custom` value is
 sanitized to `ASC` and the SQL sort part is never set to use the
 `option_order` db field.

 Props oztaser, espellcaste, niftythree

 Fixes #8623 (trunk)
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8623#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac