[buddypress-trac] [BuddyPress Trac] #8727: 452 failing tests due to wrong use of cache key

[buddypress-trac]

#8727: 452 failing tests due to wrong use of cache key
------------------------------+---------------------
 Reporter:  imath             |       Owner:  imath
     Type:  defect (bug)      |      Status:  closed
 Priority:  high              |   Milestone:  11.0.0
Component:  Core              |     Version:
 Severity:  major             |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by imath):

 * owner:  (none) => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"13309" 13309]:
 {{{
 #!CommitTicketReference repository="" revision="13309"
 Adapt to WP Cache API latest change about cache key requirements

 In WordPress 6.1, a cache key needs to be an integer or a "not empty"
 string. See [https://core.trac.wordpress.org/changeset/53818 WP53818]
 changeset.

 After analysing the failing PHPUnit failing tests, it seems we were not
 careful enough about cache key checks in a few cases:

 - When generating an activity comment without a corresponding parent
 activity in our tests.
 - When trying to cache a group membership ID for the group creator before
 this membership has been created.
 - When trying to check if a member had a member type or a group had a
 group type using an empty string although into 2 of our unit tests.

 Fixes #8727
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8727#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac