[buddypress-trac] [BuddyPress Trac] #8727: 452 failing tests due to wrong use of cache key

[buddypress-trac]

#8727: 452 failing tests due to wrong use of cache key
--------------------------+-------------------------
 Reporter:  imath         |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  high          |  Milestone:  11.0.0
Component:  Core          |    Version:
 Severity:  major         |   Keywords:  needs-patch
--------------------------+-------------------------
 I believe the reason is in
 [https://core.trac.wordpress.org/changeset/53818 WP's 53818 changeset].
 The WP Cache API is less permissive in WordPress 6.1 and throws
 "Unexpected incorrect usage notice" when the cache key is not an integer
 nor a not empty string.

 After a analysing the 2 first failing tests it looks like it corresponds
 to:
 - an activity comment created without the parent activity inside the test
 (not a regular usage).
 - a group is created and the membership id is null for the creator at the
 time the `'groups_member_before_save'` hook is fired (regular usage)

 I'm adding a first patch about it to illustrate the 2 fixes.

 450 failing tests left to fix.. which is a lot!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8727>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac