[buddypress-trac] [BuddyPress Trac] #8577: Inaccurate error message on Group Invites page

[buddypress-trac]

#8577: Inaccurate error message on Group Invites page
--------------------------+-----------------------------
 Reporter:  comminski     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Groups        |    Version:  9.1.1
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Hi, I think there is an inaccurate message in the Group Invites plugin.
 Here's the issue:

 1. Log in and friend another user
 2. Create a group
 3. Go to the group, click the 'send invites' tab and then click the
 'Friendships' tab
 4. Enter a random search term (one that will return no results)

 Expected result:
   I expected to see A message saying that ''no members were found''

 Actual result:
   The following message ''All your friends are already members of this
 group, or have already received an invite to join this group, or have
 requested to join it''.

 ----

 I don't think this message is correct as the friend has not been invited
 and and is not a group member.

 I think the problem seems to be with the logic on line 320 of the
 'ajax.php' (/buddypress/bp-templates/bp-nouveau/includes/groups/ajax.php)
 in the method 'bp_nouveau_ajax_get_users_to_invite'

 It looks like the 'No Members Found' error message will always be
 overwritten by the other message if the scope is 'friends'.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8577>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac