[buddypress-trac] [BuddyPress Trac] #8426: Update queries when new message notifications mark as read

[buddypress-trac]

#8426: Update queries when new message notifications mark as read
------------------------------+---------------------
 Reporter:  oztaser           |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  10.0.0
Component:  Messages          |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by imath):

 * keywords:  has-patch needs-testing => has-patch commit


Comment:

 Thanks again for your work on this ticket @oztaser

 I've improved a bit these new functions because we don't need the
 component name / action or other data when we have the ids :)

 I've also used these new functions to handle Notification bulk delete/mark
 actions this way we're avoiding some more queries!

 I finally added unit tests about these new functions.

 I believe the patch is ready to be committed, so I'll probably do it in a
 few days after another round of testing.

 Maybe you could look to some other parts of BuddyPress where we are using
 a loop to delete notifications one by one to see if we can add more
 performance improvements 😉. I'm thinking of activity comments maybe...

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8426#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac