[buddypress-trac] [BuddyPress Trac] #8426: Update queries when new message notifications mark as read

[buddypress-trac]

#8426: Update queries when new message notifications mark as read
-------------------------------------+---------------------
 Reporter:  oztaser                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  10.0.0
Component:  Messages                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------
Changes (by imath):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Hey, this is pretty nice 👏.

 .8.patch is including a unit test. I was able to check with this test this
 improvement replaces the ( number of message thread ) x update queries by
 1 query.

 In .8.patch I also updated the method name from `update_many()` to
 `update_id_list()`.

 You're getting close to have this committed. I have 2 last questions:

 - Shouldn't we also use
 `bp_notifications_mark_notifications_by_item_ids()` inside
 `bp_messages_screen_conversation_mark_notifications()`?
 - Maybe we should also improve
 `bp_messages_message_delete_notifications()` the same way?

 I haven't tested it yet manually, I'll try to do it asap.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8426#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac