[buddypress-trac] [BuddyPress Trac] #8470: Improve BP Directory Pages Administration parts

buddypress-trac noreply at wordpress.org
Sat Oct 9 21:24:13 UTC 2021


#8470: Improve BP Directory Pages Administration parts
----------------------------+---------------------
 Reporter:  imath           |       Owner:  imath
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:  10.0.0
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |
----------------------------+---------------------

Comment (by Offereins):

 This is a great addition for understanding WP's page directory and the
 links to BP.

 @imath One question concerning the new code: is there a reason why the
 `$post` parameter is not available in `apply_filters( 'bp_' . $this->id .
 '_admin_directory_states', $states );`?

 Since the filter will run for all posts, it is missing relevant context as
 to when it is triggered. Alternatively, the `if ( $this->has_directory )
 {` check could contain an additional check for `$post` being the actual
 directory page as well, so the filter will only be called for the relevant
 page.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8470#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list