[buddypress-trac] [BuddyPress Trac] #8582: Add site membership requests.

[buddypress-trac]

#8582: Add site membership requests.
-------------------------------------+---------------------
 Reporter:  dcavins                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  10.0.0
Component:  Members                  |     Version:  9.1.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------

Comment (by imath):

 Thanks again for the great work you've being doing on this ticket
 @dcavins. I've tested the patch and it works pretty fine 👏

 I've refeshed it (see
 [https://buddypress.trac.wordpress.org/attachment/ticket/8582/8582.6-refreshed.patch
 8582.6-refreshed.patch]) and made sure to remove the `src/bp-members/bp-
 members-membership-requests.php.rej` that was in your version and confused
 me a bit at the beginning.

 Once 8582.6-refreshed.patch is applied, you can apply
 [https://buddypress.trac.wordpress.org/attachment/ticket/8582/8582.7.patch
 8582.7.patch]. This second patch contains some improvement suggestions:
 - Add more escaping functions
 - Fix missing textdomain
 - Add some code standards/format/inline documentation improvements
 - Limit code duplication into the WP List Tables (see
 `bp_members_admin_preview_signup_profile_info()` &
 `bp_members_admin_format_xprofile_field_for_display()`)

 I've also added 2 JavaScript files to make sure the Signup's profile info
 modal is more inline with the Hello one.

 If these are fine with you, the last step (unless you find other
 improvements) would be to give it a last check on a multisite config as I
 haven't done so.

 I can see the finish line!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8582#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac