[buddypress-trac] [BuddyPress Trac] #8581: Extending no content activities with images and call of actions

[buddypress-trac]

#8581: Extending no content activities with images and call of actions
-----------------------------+---------------------
 Reporter:  vapvarun         |       Owner:  (none)
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  10.0.0
Component:  Activity         |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+---------------------

Comment (by oztaser):

 Hi there!

 I've read the patch and test it locally. It works very well. Thanks for
 working on that, @imath. I've just noticed a few code style problem :) :
 * There is a `var_dump` on `bp_activity_has_content` function :)
 * I think there is no need to create empty `$avatar_id` variable on
 `bp_avatar_get_version_src`
 * There is no need `else` block on `add_revision` line 592. We can just
 move the line out side of the `else` block.

 I have one last concern about the `new_avatar` activity feature and other
 new activities we store old file. Should we remove avatars from history
 directory when `new_avatar` activity is removed? What you think about
 that? I think it can be important for user privacy.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8581#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac