[buddypress-trac] [BuddyPress Trac] #8581: Extending no content activities with images and call of actions

buddypress-trac noreply at wordpress.org
Sat Nov 20 13:53:34 UTC 2021

#8581: Extending no content activities with images and call of actions
 Reporter:  vapvarun         |       Owner:  (none)
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  10.0.0
Component:  Activity         |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-refresh    |
Changes (by imath):

 * keywords:  dev-feedback needs-refresh => needs-refresh


 @vapvarun I've just tested your patch, generated activities are looking


 I have a few suggestions I'd like you to work on 🙏. Let's focus on
 existing activity types first.

 ==== the `new_avatar` activity type ====

 1. Including the cover image into the generated activity is problematic
 imho. It introduces a new question: Which one should we use? The one that
 was available at the time the avatar was changed or the latest one, in
 your patch it's the latest one. I believe, we shouldn't include it at all
 to focus on what has changed: the avatar.
 2. We should probably use another class than `.avatar` otherwise the theme
 may resize it. In the screen-capture, TwentyNineteen is doing so. I'd
 suggest `.profile-image` instead.
 3. The avatar should be full, maybe centered? Only the `@username` should
 be added and the link could be the activity directory permalink +
 `?r=username` this way it add `@username` into the activity `whats-new`
 textarea. Well actually what about this layout:

 ||||  Avatar      ||
 || Mention @username || View Profile ||
 ==== The friendship activity type ====


 I think this one can stay the way it is, or we could simply replace the
 `.avatar` class by a `.profile-image` one.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8581#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list